[ 
https://issues.apache.org/jira/browse/HBASE-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590633#comment-13590633
 ] 

Jonathan Hsieh commented on HBASE-7360:
---------------------------------------

+1. I didn't look at the patch carefully, but assume that since the tests pass 
and since it should be essentially the same version that matteo has ported in 
the past.

However on commit let's update the jira description and include the exact list 
of jiras that have been included in this mega backport so we know what is in 
and what else needs backporting (like the spell fixes).  Ideally we'd include 
the list of original jiras in the commit message and list places (or at least 
mark off the patch) where this back port is significantly different from trunk. 
 With regards to HBASE-7969, I don't care if it is in or out of this mega patch 
as long it is documented to be in or out properly.

Maybe have a commit message like:

{code}
HBASE-7360 Backport Snapshots to 0.94

This patch includes:
  HBASE-6610 HFileLink: Hardlink alternative for snapshot restore
  HBASE-6765 Take a Snapshot interface
    This patch is significantly different because of the RPC changes between 
0.94/0.96
  HBASE-6571 Generic multi-thread/cross-process error handling framework
  HBASE-6353 Snapshots shell
  HBASE-7107 Snapshot References Utils (FileSystem Visitor)
  HBASE-6863 Offline snapshots
  HBASE-6865 Snapshot File Cleaners
  HBASE-6777 Snapshot Restore Interface
  HBASE-6230 Clone/Restore Snapshots
  HBASE-6802 Export Snapshot 
  ... blah blah blah...
{code}


                
> Snapshot 0.94 Backport 
> -----------------------
>
>                 Key: HBASE-7360
>                 URL: https://issues.apache.org/jira/browse/HBASE-7360
>             Project: HBase
>          Issue Type: New Feature
>          Components: snapshots
>    Affects Versions: 0.94.3
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 0.94.7
>
>         Attachments: 7360-v1.patch, HBASE-7360-v0.patch
>
>
> Backport snapshot code to 0.94
> The main changes needed to backport the snapshot are related to the protobuf 
> vs writable rpc.
> Offline Snapshot
>  * HBASE-6610 - HFileLink: Hardlink alternative for snapshot restore
>  * HBASE-6765 - Take a Snapshot interface
>  * HBASE-6571 - Generic multi-thread/cross-process error handling framework
>  * HBASE-6353 - Snapshots shell
>  * HBASE-7107 - Snapshot References Utils (FileSystem Visitor)
>  * HBASE-6863 - Offline snapshots
>  * HBASE-6865 - Snapshot File Cleaners
>  * HBASE-6777 - Snapshot Restore Interface
>  * HBASE-6230 - Clone/Restore Snapshots
>  * HBASE-6802 - Export Snapshot

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to