[
https://issues.apache.org/jira/browse/HBASE-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599274#comment-13599274
]
Himanshu Vashishtha commented on HBASE-8028:
--------------------------------------------
Thanks for the review Ted.
bq. Can CF version checking be done above so that we don't accumulate KeyValues
which would not be used in rollback ?
The patch is doing that. oldKVs is instantiated only when CF#maxVersion = 1.
{code}
List<KeyValue> oldKvs = null;
if(store.getFamily().getMaxVersions() == 1)
oldKvs = new ArrayList<KeyValue>(family.getValue().size());//
better than default.
{code}
> Append, Increment don't handle wal-sync exceptions correctly
> ------------------------------------------------------------
>
> Key: HBASE-8028
> URL: https://issues.apache.org/jira/browse/HBASE-8028
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.5
> Reporter: Himanshu Vashishtha
> Assignee: Himanshu Vashishtha
> Fix For: 0.95.0
>
> Attachments: HBase-8028-v1.patch
>
>
> In case there is an exception while doing the log-sync, the memstore is not
> rollbacked, while the mvcc is _always_ forwarded to the writeentry created at
> the beginning of the operation. This may lead to scanners seeing results
> which are not synched to the fs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
