[
https://issues.apache.org/jira/browse/HBASE-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599326#comment-13599326
]
Ted Yu commented on HBASE-8028:
-------------------------------
Comment on code style:
{code}
+ if(store.getFamily().getMaxVersions() == 1)
+ oldKvs = new ArrayList<KeyValue>(family.getValue().size());//
better than default.
{code}
Space should be inserted between if and (
Please add curly braces for the assignment.
This applies to other changes in the patch.
{code}
+ * Since the mvcc readpoint is not forwarded untill we are done with this
rollback, it shouldn't
{code}
Typo: untill
{code}
+ * Rollbacks an upsert transaction. It removes the kvs which share the same
readpoint as the
+ * passed mvccStartPoint, and then replays the oldKVs passed as in
oldKVsToReplay.
{code}
I think 'Rolls back' would be better than 'Rollbacks'
'passed as in' -> 'passed in as'
In deleteKVWithMvccReadPoint(), there're three LOG.warn() statements. Should
they be at DEBUG or TRACE level ?
> Append, Increment don't handle wal-sync exceptions correctly
> ------------------------------------------------------------
>
> Key: HBASE-8028
> URL: https://issues.apache.org/jira/browse/HBASE-8028
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.5
> Reporter: Himanshu Vashishtha
> Assignee: Himanshu Vashishtha
> Fix For: 0.95.0
>
> Attachments: HBase-8028-v1.patch
>
>
> In case there is an exception while doing the log-sync, the memstore is not
> rollbacked, while the mvcc is _always_ forwarded to the writeentry created at
> the beginning of the operation. This may lead to scanners seeing results
> which are not synched to the fs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
