[
https://issues.apache.org/jira/browse/HBASE-8219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617493#comment-13617493
]
Ted Yu commented on HBASE-8219:
-------------------------------
{code}
+ throw new IOException("Unable to merge region " + a + " and " + b);
{code}
'merge region' -> 'merge regions'
{code}
+ dstRegion = rmt.execute(null, null);
{code}
Looking into execute() method:
{code}
HRegion mergedRegion = createMergedRegion(server, services);
openMergedRegion(server, services, mergedRegion);
transitionZKNode(server, services);
return mergedRegion;
{code}
The second and third calls wouldn't have effect because server is null.
So if we expose createMergedRegion() as public method, we can call it directly.
> Align Offline Merge with Online Merge
> -------------------------------------
>
> Key: HBASE-8219
> URL: https://issues.apache.org/jira/browse/HBASE-8219
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.95.0
> Reporter: Matteo Bertozzi
> Assignee: chunhui shen
> Attachments: hbase-8219v1.patch
>
>
> After HBASE-7403 we now have two different tools for online and offline
> merge, and the result produced by the two are different. (the online one
> works with snapshots, the offline not)
> We should remove the offline one, or align it to the online code.
> Most of the offline code in HRegion.merge() can be replaced with the one in
> RegionMergeTransaction, used by the online version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
