[ 
https://issues.apache.org/jira/browse/HBASE-8219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619075#comment-13619075
 ] 

Matteo Bertozzi commented on HBASE-8219:
----------------------------------------

A compaction is called on the merge region, this means that after that call the 
region will not have reference files, but the real data. right?
so at this point the other two regions are removed by using the archiver, are 
they empty after the compaction? they should, right... maybe add an assert 
there.

if what I have said above is true, I'm +1 on the patch (with the assert if you 
want)
                
> Align Offline Merge with Online Merge
> -------------------------------------
>
>                 Key: HBASE-8219
>                 URL: https://issues.apache.org/jira/browse/HBASE-8219
>             Project: HBase
>          Issue Type: Task
>          Components: regionserver
>    Affects Versions: 0.95.0
>            Reporter: Matteo Bertozzi
>            Assignee: chunhui shen
>         Attachments: hbase-8219v1.patch, hbase-8219v2.patch
>
>
> After HBASE-7403 we now have two different tools for online and offline 
> merge, and the result produced by the two are different. (the online one 
> works with snapshots, the offline not)
> We should remove the offline one, or align it to the online code.
> Most of the offline code in HRegion.merge() can be replaced with the one in 
> RegionMergeTransaction, used by the online version.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to