[ 
https://issues.apache.org/jira/browse/HBASE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630880#comment-13630880
 ] 

Ted Yu commented on HBASE-8272:
-------------------------------

{code}
+  private long compactionCheckMultiplier;
{code}
Do we need a long above ? How about an int ?
{code}
+    this.compactionCheckMultiplier = 
conf.getLong(COMPACTCHECKER_INTERVAL_MULTIPLIER_KEY, 1000);
{code}
Should we check that the multiplier isn't 0 ? If it is 0, we would have 
arithmetic exception here:
{code}
+            if (iteration % multiplier != 0) continue;
{code}
                
> make compaction checker frequency configurable per table/cf
> -----------------------------------------------------------
>
>                 Key: HBASE-8272
>                 URL: https://issues.apache.org/jira/browse/HBASE-8272
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-8272-v0.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to