[ 
https://issues.apache.org/jira/browse/HBASE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644871#comment-13644871
 ] 

Ted Yu commented on HBASE-8272:
-------------------------------

Some nit:
{code}
+    if (this.compactionCheckMultiplier <= 0) {
+      LOG.error("Compaction check period multiplier must be positive, setting 
default");
{code}
Please put the default value in log above.
{code}
-   * Gets the Memstore flush size for the region that this store works with.
    * TODO: remove after HBASE-7236 is fixed.
{code}
HBASE-7236 has been fixed.
{code}
+   *         will be ascertained every multiplier * 
HConstants.THREAD_WAKE_FREQUENCY
{code}
The sentence seems to be incomplete.
                
> make compaction checker frequency configurable per table/cf
> -----------------------------------------------------------
>
>                 Key: HBASE-8272
>                 URL: https://issues.apache.org/jira/browse/HBASE-8272
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-8272-v0.patch, HBASE-8272-v1.patch, 
> HBASE-8272-v2.patch, HBASE-8272-v2.patch
>
>
> Makes the compaction checker frequency configurable per table/cf; that is 
> useful for compaction schemes where many compactions can be available at any 
> time, so the default checks/requests that HBase performs may be insufficient.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to