[ 
https://issues.apache.org/jira/browse/HBASE-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631980#comment-13631980
 ] 

Jeffrey Zhong commented on HBASE-8321:
--------------------------------------

The semantics of the existing heartbeat is progress heart beat, if we got a 
slow worker we can re-assigne the work to others. It also guards the scenario 
when a splitlogworker dies. After the patch, it seems to me we lose both 
functionalities. Even when splitworker dies, do still we get heart beats from 
the chore?

Thanks,
-Jeffrey
                
> Log split worker should heartbeat to avoid timeout
> --------------------------------------------------
>
>                 Key: HBASE-8321
>                 URL: https://issues.apache.org/jira/browse/HBASE-8321
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: trunk-8321_v1.patch
>
>
> Currently, hlog splitter could spend quite sometime to split a log in case 
> any HDFS issue and recoverLease/retry opening is needed.  If distributed log 
> split manager times out the log worker, other log worker to take over will 
> run into the same issue.
> Ideally, we should not need a timeout monitor.  Since we have a timeout 
> monitor for DSL now, the worker should heartbeat to avoid wrong/unneeded 
> timeouts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to