[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633144#comment-13633144
]
Jonathan Hsieh commented on HBASE-8352:
---------------------------------------
The insertion point in the code is correct but the fs.exists(oldSnapshotDir)
check is not sufficient -- if hdfs snapshots is on, there will potentially be a
.snapshot dir "exists" but that corresponds to the hdfs snapshot. We need to
go into the .snapshot dir and see if there are any .snapshotinfo files present
one directory level deeper.
See dir structure of a snapshot in
https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java#L38
> Rename '.snapshot' directory
> ----------------------------
>
> Key: HBASE-8352
> URL: https://issues.apache.org/jira/browse/HBASE-8352
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Blocker
> Fix For: 0.98.0, 0.94.7, 0.95.1
>
> Attachments: 8352-0.94-v1.txt, 8352-0.94-v2.txt, 8352-trunk.txt,
> 8352-trunk-v2.txt
>
>
> Testing HBase Snapshot on top of Hadoop's Snapshot branch
> (http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-2802/), we found
> that both features used '.snapshot' directory to store metadata.
> HDFS (built from HDFS-2802 branch) doesn't allow paths with .snapshot as a
> component
> From discussion on [email protected], (see
> http://search-hadoop.com/m/kY6C3cXMs51), consensus was to rename '.snapshot'
> directory in HBase so that both features can co-exist smoothly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
