[ 
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633204#comment-13633204
 ] 

Lars Hofhansl commented on HBASE-8352:
--------------------------------------

This does not seem right:
{code}
+    // check if an older version of snapshot directory was present
+    Path oldSnapshotDir = new Path(mfs.getRootDir(), ".snapshot");
+    FileSystem fs = mfs.getFileSystem();
+    List<SnapshotDescription> ss = getCompletedSnapshots();
+    if (ss != null && !ss.isEmpty()) {
+      LOG.error("Snapshots from an earlier release were found under: " + 
oldSnapshotDir);
+      LOG.error("Please rename the directory as " + 
HConstants.SNAPSHOT_DIR_NAME);
+    }
{code}
If never used the old snapshot dir for anything and will just return the new 
snapshots anyway.
                
> Rename '.snapshot' directory
> ----------------------------
>
>                 Key: HBASE-8352
>                 URL: https://issues.apache.org/jira/browse/HBASE-8352
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Blocker
>             Fix For: 0.98.0, 0.94.7, 0.95.1
>
>         Attachments: 8352-0.94-v1.txt, 8352-0.94-v2.txt, 8352-trunk.txt, 
> 8352-trunk-v2.txt, 8352-trunk-v3.txt
>
>
> Testing HBase Snapshot on top of Hadoop's Snapshot branch 
> (http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-2802/), we found 
> that both features used '.snapshot' directory to store metadata.
> HDFS (built from HDFS-2802 branch) doesn't allow paths with .snapshot as a 
> component
> From discussion on [email protected], (see 
> http://search-hadoop.com/m/kY6C3cXMs51), consensus was to rename '.snapshot' 
> directory in HBase so that both features can co-exist smoothly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to