[ 
https://issues.apache.org/jira/browse/HBASE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636968#comment-13636968
 ] 

Jean-Marc Spaggiari commented on HBASE-8379:
--------------------------------------------

qt. There is no need to turn off balancer if it was off before 
bin/graceful_stop.sh was called.
Do we have a shell command to check balancer status without updating it? 
balance_switch need an argument. So we can't just get the status and disable if 
it's enable. And calling the shell once to get the status and another time to 
disable it is not really better/faster than calling it to disable directly, no?

qt. Can you enclose the above command in back quotes and display its return 
value ?
If we want to display the result, we simply need to remove the "&> /dev/null". 
But it's not very beautiful. Even if we just get the "true" or "false" 
returned, it will alsway be false since we disabled the balancer previously. So 
I'm not really sure to get what you want to display. Can you please confirm?
                
> bin/graceful_stop.sh does not return the balancer to original state
> -------------------------------------------------------------------
>
>                 Key: HBASE-8379
>                 URL: https://issues.apache.org/jira/browse/HBASE-8379
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Nick Dimiduk
>         Attachments: HBASE-8379-v0-trunk.patch
>
>
> {{graceful_stop.sh}} starts by explicitly disabling the balancer. It should 
> make note of the original balancer state and then restore that state upon 
> completion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to