[
https://issues.apache.org/jira/browse/HBASE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643827#comment-13643827
]
Ted Yu commented on HBASE-8446:
-------------------------------
For SnapshotManager:
{code}
+ // Remove from the "in-progress" list once completed
+ if (h.isFinished()) {
+ snapshotHandlers.remove(snapshot.getTable());
+ }
+
return h;
{code}
Should null be returned when h.isFinished() is true ? I ask because the javadoc
says:
{code}
* Return the handler if it is currently running and has the same snapshot
target name.
{code}
{code}
+ assertFalse("Manager is in process when there is no current handler",
+ manager.isTakingSnapshot(tableName ));
{code}
Nit: remove the space between tableName and ')' above.
> Allow parallel snapshot of different tables
> -------------------------------------------
>
> Key: HBASE-8446
> URL: https://issues.apache.org/jira/browse/HBASE-8446
> Project: HBase
> Issue Type: Improvement
> Components: snapshots
> Affects Versions: 0.95.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Minor
> Fix For: 0.95.2
>
> Attachments: HBASE-8446-v0.patch, HBASE-8446-v1.patch
>
>
> currently only one snapshot at the time is allowed.
> Like for the restore, we should allow taking snapshot of different tables in
> parallel.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
