[
https://issues.apache.org/jira/browse/HBASE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643944#comment-13643944
]
Matteo Bertozzi commented on HBASE-8446:
----------------------------------------
{quote}Should null be returned when h.isFinished() is true ?{quote}
No, if the handler is still in the map means that no one has already called
isSnapshotDone()
and isSnapshotDone() raise an exception if the snapshot is finished with an
error handler.rethrowException()
"currently running" in this case refers more to the client state where the
snapshot() operation is not completed client side. The @return docs has the
strict correct meaning "null if doesn't match, else a live handler."
{quote}
I think it would be better if
TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is split into
two tests: one where single table is snapshotted and one where two tables are
snapshotted concurrently. In the second case, there is no conflict and we
should have two snapshots.
{quote}
If you just call takeSnapshotAsync() two times you're not sure that the
operations are concurrent, since the first one may end before the second one
starts, so I like the idea of having n takeSnapshotAsync() running and at the
end check if there're at least two snapshot of different tables, but maybe I
don't have understood what is your idea...
> Allow parallel snapshot of different tables
> -------------------------------------------
>
> Key: HBASE-8446
> URL: https://issues.apache.org/jira/browse/HBASE-8446
> Project: HBase
> Issue Type: Improvement
> Components: snapshots
> Affects Versions: 0.95.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Minor
> Fix For: 0.95.2
>
> Attachments: HBASE-8446-v0.patch, HBASE-8446-v1.patch
>
>
> currently only one snapshot at the time is allowed.
> Like for the restore, we should allow taking snapshot of different tables in
> parallel.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
