[ 
https://issues.apache.org/jira/browse/HBASE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646224#comment-13646224
 ] 

Sergey Shelukhin commented on HBASE-8446:
-----------------------------------------

{code}
   * The thread limitation on the executorService's thread pool for snapshots 
ensures the
   * snapshot won't be started if there is another snapshot already running. 
Does
{code} 
What does this comment say? Thread number can be >1.

{code}
      this.executorService.submit(handler);
      this.snapshotHandlers.put(snapshot.getTable(), handler);
{code}
What ensures that put doesn't replace the old value?

{code}
 /** Wait time before removing a finished sentinel from the in-progress map */
{code}
Is it possible to add explanation why this is necessary?



                
> Allow parallel snapshot of different tables
> -------------------------------------------
>
>                 Key: HBASE-8446
>                 URL: https://issues.apache.org/jira/browse/HBASE-8446
>             Project: HBase
>          Issue Type: Improvement
>          Components: snapshots
>    Affects Versions: 0.95.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 0.95.2
>
>         Attachments: HBASE-8446-94.patch, HBASE-8446-v0.patch, 
> HBASE-8446-v1.patch, HBASE-8446-v2.patch, HBASE-8446-v3.patch, 
> HBASE-8446-v4.patch
>
>
> currently only one snapshot at the time is allowed.
> Like for the restore, we should allow taking snapshot of different tables in 
> parallel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to