[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656639#comment-13656639
]
Enis Soztutar commented on HBASE-5995:
--------------------------------------
Thanks Sergey for taking a look.
bq. End should not be called only if "isClosed || !closeBarrier.beginOp()" is
false. isClosed needs to be checked lest "closed" changed
Right. Closed is not changed once it is set to true, but it might change
between false -> true.
bq. In fact maybe it's better to move that if before "try"? (and keep
logRollRunning in)
Then we have to replicate the log and return statements. This looked cleaner.
bq. This "if" is pointless... should it throw in other cases?
yes, it should definitely throw the exception in else.
> Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
> ------------------------------------------------------------
>
> Key: HBASE-5995
> URL: https://issues.apache.org/jira/browse/HBASE-5995
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Reporter: stack
> Assignee: Enis Soztutar
> Priority: Blocker
> Fix For: 0.98.0, 0.95.1
>
> Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch
>
>
> HBASE-5984 disabled this flakey test (See the issue for more). This issue is
> about getting it enabled again. Made a blocker on 0.96.0 so it gets
> attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
