[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13657632#comment-13657632
]
stack commented on HBASE-5995:
------------------------------
If we do this:
{code}
- sync();
+ try {
+ sync();
+ } catch (IOException ioe) {
+ if (ioe.getMessage().contains("DFSOutputStream is closed")) {
+ //do not throw this here, sync() failed we will just close the
writer
+ }
+ }
{code}
... we will skip this:
{code}
LOG.error("Failed close of HLog writer", e);
int errors = closeErrorCount.incrementAndGet();
if (errors <= closeErrorsTolerated && !hasDeferredEntries()) {
LOG.warn("Riding over HLog close failure! error count="+errors);
} else {
if (hasDeferredEntries()) {
LOG.error("Aborting due to unflushed edits in HLog");
}
// Failed close of log file. Means we're losing edits. For now,
// shut ourselves down to minimize loss. Alternative is to try and
// keep going. See HBASE-930.
FailedLogCloseException flce =
new FailedLogCloseException("#" + currentfilenum);
flce.initCause(e);
throw flce;
}
{code}
... in particular, the abort of the server because we failed sync out some
deferred edits.
Should the close into a finally?
Else looks good
> Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
> ------------------------------------------------------------
>
> Key: HBASE-5995
> URL: https://issues.apache.org/jira/browse/HBASE-5995
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Reporter: stack
> Assignee: Enis Soztutar
> Priority: Blocker
> Fix For: 0.98.0, 0.95.1
>
> Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch
>
>
> HBASE-5984 disabled this flakey test (See the issue for more). This issue is
> about getting it enabled again. Made a blocker on 0.96.0 so it gets
> attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
