[ https://issues.apache.org/jira/browse/HBASE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670072#comment-13670072 ]
Julian Zhou commented on HBASE-8642: ------------------------------------ Thanks for review, [~mbertozzi] and [~jesse_yates]. 1) for the logic inside deleteSnapshotsByTable(), I was just copying from #deleteSnapshots(final Pattern pattern), is it ok? 2) locally applied the comment changes; 3) for shell support, I just studied the 6353. Seems there are 2 options: a) add new "list_snapshots_by_table.rb" and "delete_snapshot_by_table.rb" to separate the case from regex based operation; b) still in "list_snapshots.rb" and "delete_snapshot.rb", but add "-table" option to branch out from regex based operation path. seems that "delete_snapshot.rb" has no logic for regex based operation currently, will we also support it in this stream? > [Snapshot] List and delete snapshot by table > -------------------------------------------- > > Key: HBASE-8642 > URL: https://issues.apache.org/jira/browse/HBASE-8642 > Project: HBase > Issue Type: Improvement > Components: snapshots > Affects Versions: 0.98.0, 0.95.0, 0.95.1, 0.95.2 > Reporter: Julian Zhou > Assignee: Julian Zhou > Priority: Minor > Fix For: 0.98.0, 0.95.0, 0.95.1, 0.95.2 > > Attachments: 8642-trunk-0.95-v0.patch > > > Support list and delete snapshot by table name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira