[
https://issues.apache.org/jira/browse/HBASE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670087#comment-13670087
]
Matteo Bertozzi commented on HBASE-8642:
----------------------------------------
{quote}1) for the logic inside deleteSnapshotsByTable(), I was just copying
from #deleteSnapshots(final Pattern pattern), is it ok?{quote}
No is not ok, your new code should be better than the existent one :)
It's not wrong, but it's just an extra copy... should be fixed also in
deleteSnapshots()
{quote}
3) for shell support, I just studied the 6353. Seems there are 2 options:
a) add new "list_snapshots_by_table.rb" and "delete_snapshot_by_table.rb" to
separate the case from regex based operation;
b) still in "list_snapshots.rb" and "delete_snapshot.rb", but add "-table"
option to branch out from regex based operation path.
{quote}
Having a -table option don't seems to be inline with the current shell, I think
that stuff like {{TABLE => 'name*' }} is used elsewhere (see create).. but I
will pick the easy way with a new .rb
{quote}seems that "delete_snapshot.rb" has no logic for regex based operation
currently, will we also support it in this stream?{quote}
yeah the delete snapshots is not in the shell at the moment.. I think there's a
jira or a mention to open a new jira for the shell support.
[~jmhsieh] was against the regex delete. not sure what he thinks about this
one... but at least this doesn't contain a regex for the table name.
> [Snapshot] List and delete snapshot by table
> --------------------------------------------
>
> Key: HBASE-8642
> URL: https://issues.apache.org/jira/browse/HBASE-8642
> Project: HBase
> Issue Type: Improvement
> Components: snapshots
> Affects Versions: 0.98.0, 0.95.0, 0.95.1, 0.95.2
> Reporter: Julian Zhou
> Assignee: Julian Zhou
> Priority: Minor
> Fix For: 0.98.0, 0.95.0, 0.95.1, 0.95.2
>
> Attachments: 8642-trunk-0.95-v0.patch
>
>
> Support list and delete snapshot by table name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
