[ 
https://issues.apache.org/jira/browse/HIVE-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371491#comment-14371491
 ] 

Sergio Peña commented on HIVE-10031:
------------------------------------

I'm just worried about this part of the code:

{code}
public static void copyTableJobPropertiesToConf(TableDesc tbl, JobConf job) {
    ....
    for (Map.Entry<String, String> entry : jobProperties.entrySet()) {
      job.set(entry.getKey(), entry.getValue());
    }
}
{code}

could the block replace variables in JobConf that are different in the 
jobProperties?

> Modify the using of jobConf variable in ParquetRecordReaderWrapper constructor
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-10031
>                 URL: https://issues.apache.org/jira/browse/HIVE-10031
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Dong Chen
>            Assignee: Dong Chen
>         Attachments: HIVE-10031-parquet.patch
>
>
> In {{ParquetRecordReaderWrapper}} constructor, it create splits, set 
> projections and filters in conf, create task context, and then create Parquet 
> record reader. In this procedure, we could improve the logic of conf usage:
> 1. the clone of jobConf is not necessary. This could speed up getRecordReader 
> a little.
> 2. the updated jobConf is not passed to Parquet in one case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to