[
https://issues.apache.org/jira/browse/HIVE-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376012#comment-14376012
]
Sergio Peña commented on HIVE-10031:
------------------------------------
+1
I think this is good [~dongc]
> Modify the using of jobConf variable in ParquetRecordReaderWrapper constructor
> ------------------------------------------------------------------------------
>
> Key: HIVE-10031
> URL: https://issues.apache.org/jira/browse/HIVE-10031
> Project: Hive
> Issue Type: Sub-task
> Reporter: Dong Chen
> Assignee: Dong Chen
> Attachments: HIVE-10031-parquet.patch, HIVE-10031.1-parquet.patch
>
>
> In {{ParquetRecordReaderWrapper}} constructor, it create splits, set
> projections and filters in conf, create task context, and then create Parquet
> record reader. In this procedure, we could improve the logic of conf usage:
> 1. the updated jobConf is not passed to Parquet in one case.
> (https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java#L103)
> I think we should use the instance variable {{jobConf}}, which is updated
> when projectioning and filtering, instead of passed in {{oldJobConf}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
