[jira] [Commented] (HIVE-10684) Fix the unit test failures for HIVE-7553 after HIVE-10674 removed the binary jar files

[Hari Sankar Sivarama Subramaniyan (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-10684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555830#comment-14555830
 ] 

Hari Sankar Sivarama Subramaniyan commented on HIVE-10684:
----------------------------------------------------------

[~Ferd] I took a closer look at this implementation and it might be possible to 
achieve what you have done via the below addition to maven-jar-plugin in 
ql/pom.xml. Please test it after commenting out the previous change you made in 
maven-antrun-plugin(except creating the /tmp directory part) and let me know if 
this is what you intended to do.

In ql/ pom.xml,

{code}
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-jar-plugin</artifactId>
        <executions>
.....
          <execution>
            <id>RefreshedJarClassV1</id>
            <phase>prepare-package</phase>
            <goals>
              <goal>jar</goal>
            </goals>
            <configuration>
              <archive>
                <addMavenDescriptor>false</addMavenDescriptor>
              </archive>
              
<classesDirectory>${basedir}/target/test-classes</classesDirectory>
              <includes>
                <include>**/RefreshedJarClass.class</include>
              </includes>
              <finalName>RefreshedJarClassV1</finalName>
              <outputDirectory>${basedir}/target/tmp</outputDirectory>
            </configuration>
          </execution>
          <execution>
            <id>RefreshedJarClassV2</id>
            <phase>prepare-package</phase>
            <goals>
              <goal>jar</goal>
            </goals>
            <configuration>
              <archive>
                <addMavenDescriptor>false</addMavenDescriptor>
              </archive>
              
<classesDirectory>${basedir}/target/test-classes</classesDirectory>
              <includes>
                <include>**/RefreshedJarClass.class</include>
              </includes>
              <finalName>RefreshedJarClassV2</finalName>
              <outputDirectory>${basedir}/target/tmp</outputDirectory>
            </configuration>
          </execution>
        </executions>
      </plugin>
{code}

Thanks
Hari

> Fix the unit test failures for HIVE-7553 after HIVE-10674 removed the binary 
> jar files
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-10684
>                 URL: https://issues.apache.org/jira/browse/HIVE-10684
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Ferdinand Xu
>            Assignee: Ferdinand Xu
>         Attachments: HIVE-10684.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)