[
https://issues.apache.org/jira/browse/HIVE-10684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560524#comment-14560524
]
Hari Sankar Sivarama Subramaniyan commented on HIVE-10684:
----------------------------------------------------------
[~Ferd] Sorry for the delay, I have a few minor comments here.
1. For public int executeCmd (), can you make this a private function. Also the
return value from this function is not used; i think it should either be
removed or have it logged for debugging purpose.
2.
{code}
+// Files.copy(new File("/tmp/" + clazzV2FileName.toString()), dist);
{code}
The above line can be removed.
Thanks
Hari
> Fix the unit test failures for HIVE-7553 after HIVE-10674 removed the binary
> jar files
> --------------------------------------------------------------------------------------
>
> Key: HIVE-10684
> URL: https://issues.apache.org/jira/browse/HIVE-10684
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Reporter: Ferdinand Xu
> Assignee: Ferdinand Xu
> Attachments: HIVE-10684.1.patch, HIVE-10684.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
