[
https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319048#comment-16319048
]
Prasanth Jayachandran commented on HIVE-18359:
----------------------------------------------
[~kgyrtkirk] Thanks for looking at this.
HIVE-18413 seems to fix vector_grouping_sets.q. Do you want to cover
groupby_rollup_empty.q in HIVE-18413 as well? There are some diff to cte_1.q
which also has rollup so I guess its related.
I will leave the following failures as is for it to be covered in HIVE-18413
vector_grouping_sets.q
groupby_rollup_empty.q
cte_1.q
As far as this patch goes, I don't see any changes to results other than the
above tests with rollup.
> Extend grouping set limits from int to long
> -------------------------------------------
>
> Key: HIVE-18359
> URL: https://issues.apache.org/jira/browse/HIVE-18359
> Project: Hive
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Prasanth Jayachandran
> Assignee: Prasanth Jayachandran
> Attachments: HIVE-18359.1.patch, HIVE-18359.2.patch,
> HIVE-18359.3.patch, HIVE-18359.4.patch, HIVE-18359.5.patch
>
>
> Grouping sets is broken for >32 columns because of usage of Int for bitmap
> (also GROUPING__ID virtual column). This assumption breaks grouping
> sets/rollups/cube when number of participating aggregation columns is >32.
> The easier fix would be extend it to Long for now. The correct fix would be
> to use BitSets everywhere but that would require GROUPING__ID column type to
> binary which will make predicates on GROUPING__ID difficult to deal with.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
