[ 
https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319304#comment-16319304
 ] 

Prasanth Jayachandran commented on HIVE-18359:
----------------------------------------------

bq. I'm not sure how, but it seems to me that this change have somehow alters 
the groupping set results

Hmm. Any specific test case? I don't see any difference in results for the 
tests other than the ones that I mentioned above with the rollups. I tried 
digging in a lot on the rollup change but couldn't grok it. 

> Extend grouping set limits from int to long
> -------------------------------------------
>
>                 Key: HIVE-18359
>                 URL: https://issues.apache.org/jira/browse/HIVE-18359
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-18359.1.patch, HIVE-18359.2.patch, 
> HIVE-18359.3.patch, HIVE-18359.4.patch, HIVE-18359.5.patch
>
>
> Grouping sets is broken for >32 columns because of usage of Int for bitmap 
> (also GROUPING__ID virtual column). This assumption breaks grouping 
> sets/rollups/cube when number of participating aggregation columns is >32. 
> The easier fix would be extend it to Long for now. The correct fix would be 
> to use BitSets everywhere but that would require GROUPING__ID column type to 
> binary which will make predicates on GROUPING__ID difficult to deal with. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to