Peter Vary commented on HIVE-18677:

Hi [~stakiar],

Thanks for taking care of this too!

My concern is with this approach, that the isSilent value can be changed during 
the session, and as far as I understand the code, this change does not get 

Wouldn't be a good idea to move LogHelper to the common package. The problem I 
have found with this approach is, that several part of the code sets 
SessionState.in/out/err, but changing that to setters/getters we might be able 
to keep the LogHelper streams consistent too.

What do you think?



> SparkClientImpl usage of SessionState.LogHelper doesn't respect isSilent value
> ------------------------------------------------------------------------------
>                 Key: HIVE-18677
>                 URL: https://issues.apache.org/jira/browse/HIVE-18677
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark, Test
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>         Attachments: HIVE-18677.1.patch, HIVE-18677.2.patch
> In HIVE-18389 we added support for printing information to the console stream 
> in the {{spark-client}} library (by passing the raw stream into 
> {{SparkClientImpl}}. However, usage of the console doesn't respect the value 
> is {{isSilent}} in {{SessionState}}. This has been causing a few qtests to 
> fail.

This message was sent by Atlassian JIRA

Reply via email to