Sahil Takiar commented on HIVE-18677:

[~pvary] yes thats a good point. I played around with a few solutions, and 
think I basically found a better way of doing HIVE-18389 that avoids the whole 
{{LogHelper}} dependency issue.

In HIVE-18389, the {{RemoteDriver}} would send a message to the 
{{SparkClientImpl}} that contained the URL of the Web UI. I've changed this so 
that the {{RemoteSparkJobMonitor}} now sends a message to the {{RemoteDriver}} 
requesting the value of the URL. The new approach is very similar to how we get 
the application id from the {{RemoteDriver}}, as well as all the Spark job ids, 
stats, etc.

Attached an updated patch that essentially reverts HIVE-18389 and contains the 
new approach described above.

Let me know what you think.

> SparkClientImpl usage of SessionState.LogHelper doesn't respect isSilent value
> ------------------------------------------------------------------------------
>                 Key: HIVE-18677
>                 URL: https://issues.apache.org/jira/browse/HIVE-18677
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark, Test
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>         Attachments: HIVE-18677.1.patch, HIVE-18677.2.patch, 
> HIVE-18677.3.patch
> In HIVE-18389 we added support for printing information to the console stream 
> in the {{spark-client}} library (by passing the raw stream into 
> {{SparkClientImpl}}. However, usage of the console doesn't respect the value 
> is {{isSilent}} in {{SessionState}}. This has been causing a few qtests to 
> fail.

This message was sent by Atlassian JIRA

Reply via email to