[
https://issues.apache.org/jira/browse/HIVE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392606#comment-16392606
]
Kryvenko Igor commented on HIVE-18723:
--------------------------------------
[~ekoifman], Could you review?
As you mentioned in comments
{code}
/*rename(A, B) has "interesting" behavior if A and B are directories. If B
doesn't exist,
* it does the expected operation and everything that was in A is now in
B. If B exists,
* it will make A a child of B... thus make sure the rename() is done
before creating the
* meta files which will create base_x/ (i.e. B)...*/
{code}
Thus, workaround for it is delete A from B after renaming. And we will still
have subdirectories with delta files in B
> CompactorOutputCommitter.commitJob() - check rename() ret val
> -------------------------------------------------------------
>
> Key: HIVE-18723
> URL: https://issues.apache.org/jira/browse/HIVE-18723
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Kryvenko Igor
> Priority: Major
> Attachments: HIVE-18723.1.patch, HIVE-18723.2.patch,
> HIVE-18723.3.patch, HIVE-18723.patch
>
>
> right now ret val is ignored {{fs.rename(fileStatus.getPath(), newPath); }}
> Should this use {{FileUtils.ename(FileSystem fs, Path sourcePath, Path
> destPath, Configuration conf) }}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
