[ 
https://issues.apache.org/jira/browse/HIVE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393134#comment-16393134
 ] 

Eugene Koifman commented on HIVE-18723:
---------------------------------------

[~vbeshka], I don't understand the logic.  If B exists, rename will create B/A. 
 The delete you added will delete A (in B/A) so B will not have the results of 
the compaction.

> CompactorOutputCommitter.commitJob() - check rename() ret val
> -------------------------------------------------------------
>
>                 Key: HIVE-18723
>                 URL: https://issues.apache.org/jira/browse/HIVE-18723
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Kryvenko Igor
>            Priority: Major
>         Attachments: HIVE-18723.1.patch, HIVE-18723.2.patch, 
> HIVE-18723.3.patch, HIVE-18723.patch
>
>
> right now ret val is ignored {{fs.rename(fileStatus.getPath(), newPath); }}
> Should this use {{FileUtils.ename(FileSystem fs, Path sourcePath, Path 
> destPath, Configuration conf) }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to