[
https://issues.apache.org/jira/browse/HIVE-19076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425055#comment-16425055
]
Hive QA commented on HIVE-19076:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12917329/HIVE-19076.2.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9985/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9985/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9985/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-04-04 05:59:26.664
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-9985/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-04-04 05:59:26.667
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 04f3be0 HIVE-17661 : DBTxnManager.acquireLocks() - MM tables
should use shared lock for Insert (Sergey Shelukhin, reviewed by Eugene Koifman)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 04f3be0 HIVE-17661 : DBTxnManager.acquireLocks() - MM tables
should use shared lock for Insert (Sergey Shelukhin, reviewed by Eugene Koifman)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-04-04 05:59:30.315
+ rm -rf ../yetus_PreCommit-HIVE-Build-9985
+ mkdir ../yetus_PreCommit-HIVE-Build-9985
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-9985
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9985/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: patch failed:
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:6435
Falling back to three-way merge...
Applied patch to
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java'
cleanly.
error: patch failed:
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java:33
Falling back to three-way merge...
Applied patch to
'standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java'
with conflicts.
Going to apply patch with: git apply -p0
error: patch failed:
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:6435
Falling back to three-way merge...
Applied patch to
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java'
cleanly.
error: patch failed:
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java:33
Falling back to three-way merge...
Applied patch to
'standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java'
with conflicts.
U
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12917329 - PreCommit-HIVE-Build
> Fix NPE and TApplicationException in function related HiveMetastore methods
> ---------------------------------------------------------------------------
>
> Key: HIVE-19076
> URL: https://issues.apache.org/jira/browse/HIVE-19076
> Project: Hive
> Issue Type: Bug
> Reporter: Marta Kuczora
> Assignee: Marta Kuczora
> Priority: Minor
> Attachments: HIVE-19076.1.patch, HIVE-19076.2.patch
>
>
> The TestFunctions tests revealed that NPE is thrown in some cases. These NPEs
> could be prevented with a simple null check and a MetaException with a proper
> error message should be thrown instead.
> Example: NPE is thrown in the following test cases
> * testCreateFunctionNullFunctionName
> * testCreateFunctionNullDatabaseName
> * testCreateFunctionNullOwnerType
> * testCreateFunctionNullFunctionType
> * testGetFunctionNullDatabase
> * testDropFunctionNullDatabase
> * testDropFunctionNullFunctionName
> * testAlterFunctionNullDatabase
> * testAlterFunctionNullFunctionName
> * testAlterFunctionNullFunction
> * testAlterFunctionNullFunctionNameInNew
> * testAlterFunctionNullDatabaseNameInNew
> * testAlterFunctionNullOwnerTypeInNew
> * testAlterFunctionNullFunctionTypeInNew
> Also there are some alter function tests where InvalidObjectException is
> thrown with Embedded MetaStore, but TApplicationException it thrown with
> Remote MetaStore. The reason is that the InvalidObjectException is not
> defined for the alter_function method in the thrift interface, so we got the
> TApplicationException when the InvalidObjectException was thrown. In these
> cases the InvalidObjectException could be handled on the server side and
> re-throw it as a MetaException
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
