[
https://issues.apache.org/jira/browse/HIVE-19076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428795#comment-16428795
]
Hive QA commented on HIVE-19076:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} standalone-metastore: The patch generated 0 new +
594 unchanged - 18 fixed = 594 total (was 612) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
20s{color} | {color:red} The patch generated 50 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 37s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10041/dev-support/hive-personality.sh
|
| git revision | master / 6df4d6f |
| Default Java | 1.8.0_111 |
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10041/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore U: standalone-metastore |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10041/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Fix NPE and TApplicationException in function related HiveMetastore methods
> ---------------------------------------------------------------------------
>
> Key: HIVE-19076
> URL: https://issues.apache.org/jira/browse/HIVE-19076
> Project: Hive
> Issue Type: Bug
> Reporter: Marta Kuczora
> Assignee: Marta Kuczora
> Priority: Minor
> Attachments: HIVE-19076.1.patch, HIVE-19076.2.patch,
> HIVE-19076.3.patch
>
>
> The TestFunctions tests revealed that NPE is thrown in some cases. These NPEs
> could be prevented with a simple null check and a MetaException with a proper
> error message should be thrown instead.
> Example: NPE is thrown in the following test cases
> * testCreateFunctionNullFunctionName
> * testCreateFunctionNullDatabaseName
> * testCreateFunctionNullOwnerType
> * testCreateFunctionNullFunctionType
> * testGetFunctionNullDatabase
> * testDropFunctionNullDatabase
> * testDropFunctionNullFunctionName
> * testAlterFunctionNullDatabase
> * testAlterFunctionNullFunctionName
> * testAlterFunctionNullFunction
> * testAlterFunctionNullFunctionNameInNew
> * testAlterFunctionNullDatabaseNameInNew
> * testAlterFunctionNullOwnerTypeInNew
> * testAlterFunctionNullFunctionTypeInNew
> Also there are some alter function tests where InvalidObjectException is
> thrown with Embedded MetaStore, but TApplicationException it thrown with
> Remote MetaStore. The reason is that the InvalidObjectException is not
> defined for the alter_function method in the thrift interface, so we got the
> TApplicationException when the InvalidObjectException was thrown. In these
> cases the InvalidObjectException could be handled on the server side and
> re-throw it as a MetaException
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
