[ 
https://issues.apache.org/jira/browse/HIVE-19133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433425#comment-16433425
 ] 

Bharathkrishna Guruvayoor Murali commented on HIVE-19133:
---------------------------------------------------------

Thanks [~kgyrtkirk] for the review.

I added another patch which removes the part where handler thread passes 
perfLogger to the background thread.

Since I am resetting the PerfLogger anyways in compile and execution phases, I 
feel this passing of parentPerfLogger is not much useful anymore, and removing 
that part of code from SQLOperation.java helps to be completely sure that it 
won't cause any race conditions as mentioned in HIVE-18928.



Please verify this change as well.

> HS2 WebUI phase-wise performance metrics not showing correctly
> --------------------------------------------------------------
>
>                 Key: HIVE-19133
>                 URL: https://issues.apache.org/jira/browse/HIVE-19133
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2, Web UI
>            Reporter: Bharathkrishna Guruvayoor Murali
>            Assignee: Bharathkrishna Guruvayoor Murali
>            Priority: Major
>         Attachments: HIVE-19133.1.patch, HIVE-19133.2.patch, WebUI-compile 
> time query metrics.png
>
>
> The query specific WebUI metrics (go to drilldown -> performance logging) are 
> not showing up in the correct phase and are often mixed up.
> Attaching screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to