Vihang Karajgaonkar commented on HIVE-19133:

Thanks [~bharos92] for the patch. Passing Threadlocal objects across threads is 
an anti-pattern and cause weird race-conditions which are hard to debug. It 
should be noted that after this patch the Driver.run() perf metric value is 
split into two, one for compile phase and one for execution phase. This makes 
sense to me since the Driver.run() method spans across these two phases and the 
actual execution is done by different threads. I am not sure if there is value 
in keeping Driver.run metric anymore. [~thejas] [~kgyrtkirk] any thoughts on 
removing the driver.run() metric since after this patch it will become 

> HS2 WebUI phase-wise performance metrics not showing correctly
> --------------------------------------------------------------
>                 Key: HIVE-19133
>                 URL: https://issues.apache.org/jira/browse/HIVE-19133
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2, Web UI
>            Reporter: Bharathkrishna Guruvayoor Murali
>            Assignee: Bharathkrishna Guruvayoor Murali
>            Priority: Major
>         Attachments: HIVE-19133.1.patch, HIVE-19133.2.patch, WebUI-compile 
> time query metrics.png
> The query specific WebUI metrics (go to drilldown -> performance logging) are 
> not showing up in the correct phase and are often mixed up.
> Attaching screenshot.

This message was sent by Atlassian JIRA

Reply via email to