[ 
https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462854#comment-16462854
 ] 

Sahil Takiar commented on HIVE-19041:
-------------------------------------

Few comments:

* In {{Partition}} doesn't look like we properly intern the {{catName}} in 
{{setCatName}}
* Some of the optional parameters in {{SerDeInfo}} don't look properly interned 
when they get set
* Some of the calls to {{readString}} in {{FieldSchema}} don't seem to be fully 
covered. It's only interning the {{name}} parameter, but not {{type}} or 
{{comment}}.

> Thrift deserialization of Partition objects should intern fields
> ----------------------------------------------------------------
>
>                 Key: HIVE-19041
>                 URL: https://issues.apache.org/jira/browse/HIVE-19041
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 3.0.0, 2.3.2
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>         Attachments: HIVE-19041.01.patch
>
>
> When a client is creating large number of partitions, the thrift objects are 
> deserialized into Partition objects. The read method of these objects does 
> not intern the inputformat, location, outputformat which cause large number 
> of duplicate Strings in the HMS memory. We should intern these objects while 
> deserialization to reduce memory pressure. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to