[ 
https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463269#comment-16463269
 ] 

Sahil Takiar commented on HIVE-19041:
-------------------------------------

Think you missed {{bucketCols}} in {{StorageDescriptor}}, otherwise +1 pending 
Hive QA.

We can do this in a follow up JIRA, but we probably want to intern 
{{StorageDescriptor#sortCols}} too. I don't think different partitions can have 
different sort cols, so these would be duplicated across all partitions for a 
table. We will have to define a customized intern method for it because 
{{sortCols}} is a list of {{Order}} objects, but {{Order}} objects are just a 
String + int

> Thrift deserialization of Partition objects should intern fields
> ----------------------------------------------------------------
>
>                 Key: HIVE-19041
>                 URL: https://issues.apache.org/jira/browse/HIVE-19041
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 3.0.0, 2.3.2
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>         Attachments: HIVE-19041.01.patch, HIVE-19041.02.patch
>
>
> When a client is creating large number of partitions, the thrift objects are 
> deserialized into Partition objects. The read method of these objects does 
> not intern the inputformat, location, outputformat which cause large number 
> of duplicate Strings in the HMS memory. We should intern these objects while 
> deserialization to reduce memory pressure. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to