[
https://issues.apache.org/jira/browse/HIVE-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521493#comment-16521493
]
Hive QA commented on HIVE-18882:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12928876/HIVE-18882.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 14517 tests
executed
*Failed tests:*
{noformat}
TestBeeLineExceptionHandling - did not produce a TEST-*.xml file (likely timed
out) (batchId=193)
TestBeeLineHistory - did not produce a TEST-*.xml file (likely timed out)
(batchId=193)
TestBeelineArgParsing - did not produce a TEST-*.xml file (likely timed out)
(batchId=193)
TestClientCommandHookFactory - did not produce a TEST-*.xml file (likely timed
out) (batchId=193)
TestHiveCli - did not produce a TEST-*.xml file (likely timed out) (batchId=193)
TestHiveSchemaTool - did not produce a TEST-*.xml file (likely timed out)
(batchId=193)
TestIncrementalRows - did not produce a TEST-*.xml file (likely timed out)
(batchId=193)
TestShutdownHook - did not produce a TEST-*.xml file (likely timed out)
(batchId=193)
TestTableOutputFormat - did not produce a TEST-*.xml file (likely timed out)
(batchId=193)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12054/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12054/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12054/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12928876 - PreCommit-HIVE-Build
> Do Not Hide Exception in Hive Metastore Client Connection
> ---------------------------------------------------------
>
> Key: HIVE-18882
> URL: https://issues.apache.org/jira/browse/HIVE-18882
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Assignee: Manoj Narayanan
> Priority: Minor
> Labels: noob
> Attachments: HIVE-18882.1.patch, HIVE-18882.patch
>
>
> [https://github.com/apache/hive/blob/4047befe48c8f762c58d8854e058385c1df151c6/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java#L526-L531]
>
> {code:java}
> if (LOG.isDebugEnabled()) {
> LOG.warn("Failed to connect to the MetaStore Server...", e);
> } else {
> // Don't print full exception trace if DEBUG is not on.
> LOG.warn("Failed to connect to the MetaStore Server...");
> }
> {code}
> I do not understand the logic here. I always want to see the reason for the
> failure. Otherwise, I do not know why it is failing unless I restart the
> server with debug logging enabled. By that point, the error may have
> cleared. Please just use the Exception in the WARN output without adding
> confusing logging for debugging. This is never an expected behavior... that
> enabling debug would change a _warn_ level log message.
> Also... please remove the ellipsis, they add no value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
