[
https://issues.apache.org/jira/browse/HIVE-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533840#comment-16533840
]
Naveen Gangam commented on HIVE-18882:
--------------------------------------
I do not see a reason why debug needs to be enabled to be able to see the full
stack trace. Just a quick followup question though. With the retrying metastore
client in HS2, does this exception get logged many times in the HS2 log when
HMS is down? Could you test with starting a HS2 or even Hive CLI without a
running HMS to see what gets spit out?
Otherwise, change looks good to me. Thanks
> Do Not Hide Exception in Hive Metastore Client Connection
> ---------------------------------------------------------
>
> Key: HIVE-18882
> URL: https://issues.apache.org/jira/browse/HIVE-18882
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Assignee: Manoj Narayanan
> Priority: Minor
> Labels: noob
> Attachments: HIVE-18882.1.patch, HIVE-18882.2.patch, HIVE-18882.patch
>
>
> [https://github.com/apache/hive/blob/4047befe48c8f762c58d8854e058385c1df151c6/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java#L526-L531]
>
> {code:java}
> if (LOG.isDebugEnabled()) {
> LOG.warn("Failed to connect to the MetaStore Server...", e);
> } else {
> // Don't print full exception trace if DEBUG is not on.
> LOG.warn("Failed to connect to the MetaStore Server...");
> }
> {code}
> I do not understand the logic here. I always want to see the reason for the
> failure. Otherwise, I do not know why it is failing unless I restart the
> server with debug logging enabled. By that point, the error may have
> cleared. Please just use the Exception in the WARN output without adding
> confusing logging for debugging. This is never an expected behavior... that
> enabling debug would change a _warn_ level log message.
> Also... please remove the ellipsis, they add no value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
