[ https://issues.apache.org/jira/browse/HIVE-19975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526776#comment-16526776 ]
Steve Yeom commented on HIVE-19975: ----------------------------------- [~sershe] I checked with "stats_part.q". Yes it is calling HiveMetaStore::get_partitions_statistics_req method. But your additional change to AcidUtils.getTableSnapshot(): to disable to get "validWriteIdList" by HIVE_IN_TEST check: if (validWriteIdList == null && !HiveConf.getBoolVar(conf, ConfVars.HIVE_IN_TEST)) { it passes null. But according to [~jcamachorodriguez] i think you understand it is ok when we call this: validWriteIdList = getTableValidWriteIdListWithTxnList(..) I think you jumped into conclusion that multiple inserts for partitioned table case is not working at stats_part.q due to validWriteIdList == null. But that is not the case. > Checking writeIdList per table may not check the commit level of a partition > on a partitioned table > --------------------------------------------------------------------------------------------------- > > Key: HIVE-19975 > URL: https://issues.apache.org/jira/browse/HIVE-19975 > Project: Hive > Issue Type: Sub-task > Components: Transactions > Affects Versions: 4.0.0 > Reporter: Steve Yeom > Assignee: Sergey Shelukhin > Priority: Major > Fix For: 4.0.0 > > > writeIdList is per table entity but stats for a partitioned table are per > partition. > I.e., each record in PARTITIONS has an independent stats. > So if we check the validity of a partition's stats, we need to check in the > context of > a partiton. -- This message was sent by Atlassian JIRA (v7.6.3#76005)