[
https://issues.apache.org/jira/browse/HIVE-19975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529326#comment-16529326
]
Sergey Shelukhin commented on HIVE-19975:
-----------------------------------------
branch patch excluding generated files.
This patch fixes the partition case, and also:
1) Removes writeID and txnId cols from tables.
2) Makes sure all (or at least more) calls propagate txnID and partId; to avoid
breaking and adding apis, via EnvCtx for now. This is actually a bad method,
but changing more APIs is going to be another disruptive change so I can do it
as a follow-up.
3) Removes a bunch of overloads that use default values to avoid mistakes; the
values are now passed explicitly in most places. Adds comments in many places
as to why txnId/writeIdList are not being passed.
4) Adds some TODO## comments as review comments on the original patch (some in
CachedStore, etc.).
5) Restores a removed metastore API for backward compat (hence lots of
generated code changes).
6) Some other small changes.
I filed a follow-up to potentially also remove txnId argument; for now I kept
the check in place.
Attached the full patch in addition to the branch only patch, for HiveQA to
compare with branch HiveQA
> Checking writeIdList per table may not check the commit level of a partition
> on a partitioned table
> ---------------------------------------------------------------------------------------------------
>
> Key: HIVE-19975
> URL: https://issues.apache.org/jira/browse/HIVE-19975
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
> Affects Versions: 4.0.0
> Reporter: Steve Yeom
> Assignee: Sergey Shelukhin
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-19975.patch, branch-19975.nogen.patch
>
>
> writeIdList is per table entity but stats for a partitioned table are per
> partition.
> I.e., each record in PARTITIONS has an independent stats.
> So if we check the validity of a partition's stats, we need to check in the
> context of
> a partiton.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
