[
https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568535#comment-16568535
]
Vihang Karajgaonkar commented on HIVE-19937:
--------------------------------------------
HI [~stakiar] Sorry for the delay in responding. Can you please add a comment
mentioning that set method interns the duplicate strings, just before the
{{mapWork.setPathToPartitionInfo}} and {{partitionDesc.setBaseFileName}} in the
customer deserializer's read method so that its more obvious why we are calling
the set method. I feel it is easier to understand that way.
Rest looks good. Thanks for the patch. +1
> Intern fields in MapWork on deserialization
> -------------------------------------------
>
> Key: HIVE-19937
> URL: https://issues.apache.org/jira/browse/HIVE-19937
> Project: Hive
> Issue Type: Improvement
> Components: Spark
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
> Priority: Major
> Attachments: HIVE-19937.1.patch, HIVE-19937.2.patch,
> HIVE-19937.3.patch, HIVE-19937.4.patch, HIVE-19937.5.patch,
> post-patch-report.html, report.html
>
>
> When fixing HIVE-16395, we decided that each new Spark task should clone the
> {{JobConf}} object to prevent any {{ConcurrentModificationException}} from
> being thrown. However, setting this variable comes at a cost of storing a
> duplicate {{JobConf}} object for each Spark task. These objects can take up a
> significant amount of memory, we should intern them so that Spark tasks
> running in the same JVM don't store duplicate copies.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
