ASF GitHub Bot commented on HIVE-20368:

GitHub user pudidic opened a pull request:


    HIVE-20368: Remove VectorTopNKeyOperator lock (Teddy Choi)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pudidic/hive HIVE-20368

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #414
commit 149a613dcc94f90423ed1be2090ee87df8266a46
Author: Teddy Choi <pudidic@...>
Date:   2018-08-11T14:29:52Z

    HIVE-20368: Remove VectorTopNKeyOperator lock (Teddy Choi)


> Remove VectorTopNKeyOperator lock
> ---------------------------------
>                 Key: HIVE-20368
>                 URL: https://issues.apache.org/jira/browse/HIVE-20368
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Teddy Choi
>            Assignee: Teddy Choi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-20368.1.patch
> VectorTopNKeyOperator has a lock in line 199 as following.
> {code:java}
> priorityQueue.offer(WritableUtils.clone(keysWritable, getConfiguration()));
> {code}
> WritableUtils.clone calls Confgiruation.getClassByNameOrNull that has 
> synchronized block. So it needs to run without locks.

This message was sent by Atlassian JIRA

Reply via email to