[ 
https://issues.apache.org/jira/browse/HIVE-20368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577395#comment-16577395
 ] 

Hive QA commented on HIVE-20368:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12935264/HIVE-20368.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14877 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/13178/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13178/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13178/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12935264 - PreCommit-HIVE-Build

> Remove VectorTopNKeyOperator lock
> ---------------------------------
>
>                 Key: HIVE-20368
>                 URL: https://issues.apache.org/jira/browse/HIVE-20368
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Teddy Choi
>            Assignee: Teddy Choi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-20368.1.patch, HIVE-20368.2.patch
>
>
> VectorTopNKeyOperator has a lock in line 199 as following.
> {code:java}
> priorityQueue.offer(WritableUtils.clone(keysWritable, getConfiguration()));
> {code}
> WritableUtils.clone calls Confgiruation.getClassByNameOrNull that has 
> synchronized block. So it needs to run without locks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to