[
https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630249#comment-14630249
]
Ashutosh Chauhan commented on HIVE-11281:
-----------------------------------------
Didn't follow you about double spacing. Also, just trying to be consistent with
[BaseTree::toStringTree()|https://github.com/antlr/antlr3/blob/master/runtime/Java/src/main/java/org/antlr/runtime/tree/BaseTree.java#L375]
in actual string representation, which does same thing.
Will rename the field.
Test failures are unrelated.
> Memoize toStringTree() for ASTNode
> ----------------------------------
>
> Key: HIVE-11281
> URL: https://issues.apache.org/jira/browse/HIVE-11281
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
> Affects Versions: 1.0.0, 1.2.0, 1.1.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-11281.patch
>
>
> Currently it defaults to BaseTree::toStringTree() which always computes it
> recursively. For very large trees it becomes expensive. On one particular
> test query compilation time went down from 55 seconds to 2 seconds.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
