[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

[Hari Sankar Sivarama Subramaniyan (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630280#comment-14630280
 ] 

Hari Sankar Sivarama Subramaniyan commented on HIVE-11281:
----------------------------------------------------------

[~ashutoshc] 
Cant we just do this to simplify this inside ASTNode

{code}
    @Override
    public String toStringTree() {
  
      if (null != str) {
        return str;
      }
      return str=super.toStringTree();
    }
{code}

> Memoize toStringTree() for ASTNode
> ----------------------------------
>
>                 Key: HIVE-11281
>                 URL: https://issues.apache.org/jira/browse/HIVE-11281
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning
>    Affects Versions: 1.0.0, 1.2.0, 1.1.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: HIVE-11281.2.patch, HIVE-11281.patch
>
>
> Currently it defaults to BaseTree::toStringTree() which always computes it 
> recursively. For very large trees it becomes expensive. On one particular 
> test query compilation time went down from 55 seconds to 2 seconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)