[ 
https://issues.apache.org/jira/browse/HIVE-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637718#comment-14637718
 ] 

Sergey Shelukhin commented on HIVE-11259:
-----------------------------------------

EncodedReader is part of ORC, it's not related to LLAP, it's only influenced by 
LLAP in API design.
Similar to how the fact that all Reader/RecordReader/etc. APIs were dictated by 
Hive doesn't make them part of Hive, they are still part of ORC.
It's a different interface to read ORC files. How can a factory be passed in to 
create it?
Also, if the dependency is removed, to avoid creating two different Reader-s 
with potentially 2 FS objects and files, I'd need to clone Reader/ReaderImpl 
and duplicate half the functionality, only changing the record reader type. Why 
can reader create recordReader but not encodedReader?



> LLAP: clean up ORC dependencies part 1
> --------------------------------------
>
>                 Key: HIVE-11259
>                 URL: https://issues.apache.org/jira/browse/HIVE-11259
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-11259.01.patch, HIVE-11259.patch
>
>
> Before there's storage handler module, we can clean some things up



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to