[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680783#comment-16680783 ]
Hive QA commented on HIVE-20823: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947316/HIVE-20823.07.patch {color:green}SUCCESS:{color} +1 due to 12 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15521 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestCatalogNonDefaultClient.tablesList (batchId=221) org.apache.hadoop.hive.ql.TestTxnCommands3.testCleaner2 (batchId=320) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14822/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14822/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14822/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12947316 - PreCommit-HIVE-Build > Make Compactor run in a transaction > ----------------------------------- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions > Affects Versions: 3.0.0 > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)