[
https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684745#comment-16684745
]
Hive QA commented on HIVE-20823:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947931/HIVE-20823.11.patch
{color:green}SUCCESS:{color} +1 due to 20 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 28 failed/errored test(s), 15531 tests
executed
*Failed tests:*
{noformat}
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=196)
[druidmini_masking.q,druidmini_test1.q,druidkafkamini_basic.q,druidmini_joins.q,druid_timestamptz.q]
org.apache.hadoop.hive.ql.TestTxnCommands.testNonAcidToAcidConversion01
(batchId=323)
org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCompactStatsGather (batchId=307)
org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCompactStatsGather
(batchId=307)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactAfterAbort[0]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactAfterAbort[1]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreamingForSplitUpdate[0]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreamingForSplitUpdate[1]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreaming[0]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreaming[1]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort[0]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort[1]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate[0]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate[1]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming[0]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming[1]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithInsertsAndDeletes[0]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithInsertsAndDeletes[1]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithOnlyInserts[0]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithOnlyInserts[1]
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorTableNoBase
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorWithOpenInMiddle
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorPartitionWithBase
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorWithOpenInMiddle
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorTableNoBase
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorWithOpenInMiddle
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorPartitionWithBase
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorWithOpenInMiddle
(batchId=293)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14900/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14900/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14900/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 28 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12947931 - PreCommit-HIVE-Build
> Make Compactor run in a transaction
> -----------------------------------
>
> Key: HIVE-20823
> URL: https://issues.apache.org/jira/browse/HIVE-20823
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 3.0.0
> Reporter: Eugene Koifman
> Assignee: Eugene Koifman
> Priority: Major
> Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch,
> HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch,
> HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch,
> HIVE-20823.11.patch, HIVE-20823.11.patch
>
>
> Have compactor open a transaction and run the job in that transaction.
> # make compactor produced base/delta include this txn id in the folder name,
> e.g. base_7_c17 where 17 is the txnid.
> # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to
> record this txn id
> # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction
> on read and ignores this dir if this txn id is not committed in the current
> snapshot
> ## this means not only validWriteIdList but ValidTxnIdList should be passed
> along in config (if it isn't yet)
> # once this is done, {{CompactorMR.createCompactorMarker()}} can be
> eliminated and {{AcidUtils.isValidBase}} modified accordingly
> # modify Cleaner so that it doesn't clean old files until new file is visible
> to all readers
> #
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
