Eugene Koifman commented on HIVE-21036:

n/m the RB.

could {{optional TxnType txn_type,}} in {{OpenTxnRequest}} be made required 
with a default being TxnType.DEFAULT?  Seems like you wouldn't need 
{{rqst.isSetTxn_type()}} all over in that case.

looks like there hand written commens in OpenTxnRequest.java  which is a 
generated class
could you restore individual import stmts inIMetaStoreClient.java

> extend OpenTxnRequest with transaction type
> -------------------------------------------
>                 Key: HIVE-21036
>                 URL: https://issues.apache.org/jira/browse/HIVE-21036
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 4.0.0
>            Reporter: Eugene Koifman
>            Assignee: Igor Kryvenko
>            Priority: Major
>         Attachments: HIVE-21036.01.patch, HIVE-21036.02.patch, 
> HIVE-21036.03.patch
> There is a {{TXN_TYPE}} field in {{TXNS}} table.
> There is {{TxnHandler.TxnType}} with legal values.  It would be useful to 
> TxnType a {{Thrift}}, add a new {{COMPACTION}} type object and allow setting 
> it in {{OpenTxnRequest}}.
> Since HIVE-20823 compactor starts a txn and should set this.
> Down the road we may want to set READ_ONLY either based on parsing of the 
> query or user input which can make {{TxnHandler.commitTxn}} faster.

This message was sent by Atlassian JIRA

Reply via email to