[ 
https://issues.apache.org/jira/browse/HIVE-21036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739586#comment-16739586
 ] 

Eugene Koifman commented on HIVE-21036:
---------------------------------------

I don't understand your explanation about the constructors.

I meant something like "{{optional TxnType txn_type = TxnType.DEFAULT}}" in 
Thrift definition.
Apparently you can't have an item both required and with default.
But this way it's always set to the most general transaction type and places 
like Worker supply a more specific one.

> extend OpenTxnRequest with transaction type
> -------------------------------------------
>
>                 Key: HIVE-21036
>                 URL: https://issues.apache.org/jira/browse/HIVE-21036
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 4.0.0
>            Reporter: Eugene Koifman
>            Assignee: Igor Kryvenko
>            Priority: Major
>         Attachments: HIVE-21036.01.patch, HIVE-21036.02.patch, 
> HIVE-21036.03.patch
>
>
> There is a {{TXN_TYPE}} field in {{TXNS}} table.
> There is {{TxnHandler.TxnType}} with legal values.  It would be useful to 
> TxnType a {{Thrift}}, add a new {{COMPACTION}} type object and allow setting 
> it in {{OpenTxnRequest}}.
> Since HIVE-20823 compactor starts a txn and should set this.
> Down the road we may want to set READ_ONLY either based on parsing of the 
> query or user input which can make {{TxnHandler.commitTxn}} faster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to