[
https://issues.apache.org/jira/browse/HIVE-21345?focusedWorklogId=205761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205761
]
ASF GitHub Bot logged work on HIVE-21345:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/19 12:40
Start Date: 28/Feb/19 12:40
Worklog Time Spent: 10m
Work Description: hustfeiwang commented on pull request #555:
[HIVE-21345][CLI] Fix the error when hive cliDriver parses sql statement h
semicolon in a pair of double quote
URL: https://github.com/apache/hive/pull/555#discussion_r261174150
##########
File path: cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
##########
@@ -445,6 +445,17 @@ public void handle(Signal signal) {
}
break;
case '"':
+ if (!escape) {
Review comment:
> How is this different to the case below for `'\''`? Maybe I'm missing
something but I can't see a difference and the current code has both cases
dropping to the same block so the end effect would be the same surely?
There is not different to the case below for`'\''`.
I think single quotes and double quotes work the same in a sql statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205761)
Time Spent: 1h 40m (was: 1.5h)
> Hive CLIDriver parses sql statement incorrectly
> -------------------------------------------------
>
> Key: HIVE-21345
> URL: https://issues.apache.org/jira/browse/HIVE-21345
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Affects Versions: 3.1.1, 2.3.4
> Reporter: feiwang
> Assignee: feiwang
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21345.01.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Hive parse statement incorrectly when there is a semicolon in a pair of
> double quote.
> For example:
> The statement:
> {code:java}
> select * from table_a where column_a not like "%;";{code}
> Will be parsed to:
> {code:java}
> select * from table_a where column_a not like "%{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
