[
https://issues.apache.org/jira/browse/HIVE-21345?focusedWorklogId=205772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205772
]
ASF GitHub Bot logged work on HIVE-21345:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/19 12:53
Start Date: 28/Feb/19 12:53
Worklog Time Spent: 10m
Work Description: hustfeiwang commented on pull request #555:
[HIVE-21345][CLI] Fix the error when hive cliDriver parses sql statement h
semicolon in a pair of double quote
URL: https://github.com/apache/hive/pull/555#discussion_r261180675
##########
File path: cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
##########
@@ -445,6 +445,17 @@ public void handle(Signal signal) {
}
break;
case '"':
+ if (!escape) {
Review comment:
> If it's not different then why introduce duplicated code for both cases?
Surely the way it was previously both cases would drop down to the same code
block which is effectively the same as this?
Oh sorry, you are right. I found this case in spark.
Spark dependent on hive-1.2.1 which process these case incorrectly.
So I override the splitSemicolon method in SparkSQLCLIDriver with scala.
However, scala is different to java.
Scala does not need break to break case.
Thanks, I will close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205772)
Time Spent: 2h 10m (was: 2h)
> Hive CLIDriver parses sql statement incorrectly
> -------------------------------------------------
>
> Key: HIVE-21345
> URL: https://issues.apache.org/jira/browse/HIVE-21345
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Affects Versions: 3.1.1, 2.3.4
> Reporter: feiwang
> Assignee: feiwang
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21345.01.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Hive parse statement incorrectly when there is a semicolon in a pair of
> double quote.
> For example:
> The statement:
> {code:java}
> select * from table_a where column_a not like "%;";{code}
> Will be parsed to:
> {code:java}
> select * from table_a where column_a not like "%{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
